Approving because of no blocking changes

Reviewed 1 of 16 files at r2, 17 of 17 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)

ios/MullvadVPN/Coordinators/CustomLists/CustomListViewController.swift line 178 at r3 (raw file):

                    title: NSLocalizedString(
                        "CUSTOM_LISTS_DELETE_BUTTON",
                        tableName: "APIAccess",

Shouldn't those table names be different ? (i.e. custom list table names ?)

This message is valid for all localised strings in custom lists

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

ios/MullvadVPN/Coordinators/CustomLists/CustomListViewController.swift line 178 at r3 (raw file):

Yeah, my bad, I'll change it.

Reviewable status: 15 of 18 files reviewed, 4 unresolved discussions (waiting on @buggmagnet and @rablador)

ios/MullvadVPN/Coordinators/CustomLists/CustomListViewController.swift line 161 at r4 (raw file):

    private func onDelete() {
        showDeleteAlert()

FMPOV I don't see any point of making function for showDeleteAlert. the body of showDeleteAlert can be put in the onDelete directly

ios/MullvadVPN/Coordinators/CustomLists/CustomListViewController.swift line 171 at r4 (raw file):

                "CUSTOM_LISTS_DELETE_PROMPT",
                tableName: "CustomLists",
                value: "Delete \(subject.value.name)?",

based on the Figma's design it should be Delete custom list “the name of custom list”?

ios/MullvadVPN/Coordinators/CustomLists/EditCustomListCoordinator.swift line 28 at r4 (raw file):

        navigationController: UINavigationController,
        customListInteractor: CustomListInteractorProtocol,
        customList: CustomList

I think it should be part of interactor.

Reviewable status: 15 of 18 files reviewed, 4 unresolved discussions (waiting on @buggmagnet and @mojganii)

ios/MullvadVPN/Coordinators/CustomLists/CustomListViewController.swift line 161 at r4 (raw file):

Done.

ios/MullvadVPN/Coordinators/CustomLists/CustomListViewController.swift line 171 at r4 (raw file):

Yeah, but api access methods has a similar view that only says "Delete ". I thought it should be consistent, but perhaps it's better to follow the designs.

ios/MullvadVPN/Coordinators/CustomLists/EditCustomListCoordinator.swift line 28 at r4 (raw file):

I thought about it, but the custom list supplied to EditCustomListCoordinator is specific to that coordinator only and has no relation to CustomListInteractorProtocol or views where CustomListInteractorProtocal is used.

Reviewed 1 of 1 files at r5.
Reviewable status: 16 of 18 files reviewed, 3 unresolved discussions (waiting on @mojganii)

ios/MullvadVPN/Coordinators/CustomLists/CustomListViewController.swift line 171 at r4 (raw file):

I just talked to the design team about this, they said "we should follow what the desktop does"
Here included is a screenshot of the desktop.

We can follow the copy at least, if the bold title is too complicated to make, we can skip it for now

Reviewable status: 14 of 19 files reviewed, 3 unresolved discussions (waiting on @buggmagnet and @mojganii)

ios/MullvadVPN/Coordinators/CustomLists/CustomListViewController.swift line 171 at r4 (raw file):

Done.

Reviewed 2 of 3 files at r4, 3 of 3 files at r6, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @mojganii)

Reviewable status: complete! all files reviewed, all discussions resolved

ios/MullvadVPN/Coordinators/CustomLists/EditCustomListCoordinator.swift line 28 at r4 (raw file):

nit: maybe I need to change the place of the dependency.for now let's leave it